Fixing print statements#50
Open
simcard0000 wants to merge 11 commits intoscorelab:masterfrom
simcard0000:print-edits
Open
Fixing print statements#50simcard0000 wants to merge 11 commits intoscorelab:masterfrom simcard0000:print-edits
simcard0000 wants to merge 11 commits intoscorelab:masterfrom
simcard0000:print-edits
Conversation
gnomezgrave
reviewed
Dec 7, 2018
| def genGraphInfoBetweeness(self, centrality): | ||
| print "\n+++++++++++ %s ++++++++++++" % (centrality) | ||
| print "Calculating centrality values..." | ||
| print ("\n+++++++++++ %s ++++++++++++" % (centrality)) |
There was a problem hiding this comment.
Seems you're converting the code to Python 3, better to use the Python3 recommended formatting style with {}.
Author
There was a problem hiding this comment.
Sorry for the delay, but if I may ask, can you clarify what you mean by using a formatting style with { }? Do you mean for me to further format the print statements using { }? Or the code in general? Also, if you are looking to transform all the code in the application into Python 3, may I suggest using "2to3", a Python tool for converting such code?
gnomezgrave
suggested changes
Dec 7, 2018
gnomezgrave
left a comment
gnomezgrave
left a comment
There was a problem hiding this comment.
Seems you're converting the code to Python 3, better to use the Python3 recommended formatting style with {}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to issue 47, brackets were added to print statements in order to make files compatible with Python 3 forward, where print statements are now functions.